Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(legacy)!: remove ignoreBrowserslistConfig option #14429

Merged
merged 2 commits into from
Sep 22, 2023
Merged

refactor(legacy)!: remove ignoreBrowserslistConfig option #14429

merged 2 commits into from
Sep 22, 2023

Conversation

sapphi-red
Copy link
Member

Description

Given that we started always passing target option to babel in #11318, ignoreBrowserslistConfig option did nothing.
This PR removes that option.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: legacy p1-chore Doesn't change code behavior (priority) breaking change labels Sep 21, 2023
@stackblitz
Copy link

stackblitz bot commented Sep 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy previously approved these changes Sep 21, 2023
View reviewed changes
@sapphi-red @bluwy
chore: fix typo, thanks blu
eec0c97 
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@sapphi-red sapphi-red merged commit 941bb16 into vitejs:main Sep 22, 2023
9 checks passed
@sapphi-red sapphi-red deleted the refactor/legacy-remove-ignoreBrowserslistConfig branch September 22, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
breaking change p1-chore Doesn't change code behavior (priority) plugin: legacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @bluwy